Skip to content

Commit

Permalink
Add missing rbacs
Browse files Browse the repository at this point in the history
Lately blockOwnerDeletion was added (finalizer fix PR).
On OpenShift there is an additional protection, that setting blockOwnerDeletion requires
to be able to set finalizers on the owner.
The owner might be either VM or VMI.
Add the missing rbacs.

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval committed Aug 12, 2024
1 parent bb81fc5 commit b48a7c0
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
5 changes: 5 additions & 0 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ rules:
- "virtualmachines"
- "virtualmachineinstances"
verbs: ["get", "list", "watch"]
- apiGroups: ["kubevirt.io"]
resources:
- "virtualmachines/finalizers"
- "virtualmachineinstances/finalizers"
verbs: ["update"]
- apiGroups: ["k8s.cni.cncf.io"]
resources:
- ipamclaims
Expand Down
7 changes: 7 additions & 0 deletions dist/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ rules:
- get
- list
- watch
- apiGroups:
- kubevirt.io
resources:
- virtualmachines/finalizers
- virtualmachineinstances/finalizers
verbs:
- update
- apiGroups:
- k8s.cni.cncf.io
resources:
Expand Down

0 comments on commit b48a7c0

Please sign in to comment.