Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy, kustomize: provide an OpenShift overlay #21

Closed
wants to merge 1 commit into from

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Jun 7, 2024

Provide an overlay for OpenShift.

@maiqueb maiqueb requested a review from qinqon June 7, 2024 15:10
- op: add
path: /metadata/annotations
value:
service.beta.openshift.io/serving-cert-secret-name: webhook-service
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to figure out the name of the service here ... the prefix above (line 9) is not playing along here.

maybe consider removing the prefix ?...

Copy link
Collaborator

@oshoval oshoval Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye no need the prefix imo
fwiw note please that CNAO will know to do it all itself based only on dist/install.yaml

so this PR is needed only if you want to be able to deploy the repo standalone on OCP

i would even suggest the minimalist manifest kustomize if so for this
even seds or easiest possible
no need naming / namespace changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks. I had forgotten about that.

Well, it still makes sense, but, the priority surely drops quite a lot.

It would still be useful to test drive the feature early on OpenShift though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing manually only the required bit, the secret need to be "kubevirt-ipam-claims-webhook-service"
maybe you can set it as such for both U/S and D/S
without prefixing stuff (or at least not the secret) and it will work ?

(adapting to kubevirt-ipam-controller-webhook-service once time comes)

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 11, 2024
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oshoval
Copy link
Collaborator

oshoval commented Nov 10, 2024

didnt try
but this might work and maybe we can just start by having another manifest dedicated for openshift with some flag etc

https://gist.github.com/oshoval/d5db815ebea60eb1777a838bee0530b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants