Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a pull request template #53

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Aug 6, 2024

What this PR does / why we need it:
Let's get rid of the checklist that is present in the org's template.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 6, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@oshoval
Copy link
Collaborator

oshoval commented Aug 6, 2024

Indeed better, thx

@oshoval
Copy link
Collaborator

oshoval commented Aug 12, 2024

please rebase (if you want i can press rebase, but didnt want without your ack)

Let's get rid of the checklist that is present in the org's template.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@oshoval
Copy link
Collaborator

oshoval commented Aug 12, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@maiqueb
Copy link
Collaborator Author

maiqueb commented Aug 13, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@kubevirt-bot kubevirt-bot merged commit 7e23b1d into kubevirt:main Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants