Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: Use --opt-out-kv-ipam #68

Merged
merged 1 commit into from
Sep 23, 2024
Merged

cluster: Use --opt-out-kv-ipam #68

merged 1 commit into from
Sep 23, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Sep 16, 2024

What this PR does / why we need it:
Make cluster-sync going to install it anyhow.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:


@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Sep 16, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maiqueb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 16, 2024

#8 13.85 >>> Librepo error: Cannot download repomd.xml: Cannot download repodata/repomd.xFailed to download metadata (metalink: "https://mirrors.fedoraproject.org/metalink?repo=rawhide&arch=x86_64") for repository "rawhide"
#8 13.85  Librepo error: Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

some hiccup while dnf install

@oshoval
Copy link
Collaborator Author

oshoval commented Sep 16, 2024

https://pagure.io/fedora-infrastructure/issue/12183
Fedora issue here
(trying feodra:40 locally meanwhile for the other tasks)

Make cluster-sync going to install it anyhow.

Signed-off-by: Or Shoval <[email protected]>
@oshoval
Copy link
Collaborator Author

oshoval commented Sep 17, 2024

interesting, flake on unit test (unless something was changed and it will fail consistently)
https://github.com/kubevirt/ipam-extensions/actions/runs/10900433841/job/30248013978?pr=68
i think it is not related to this PR, as it changes only e2e

@maiqueb
Copy link
Collaborator

maiqueb commented Sep 17, 2024

interesting, flake on unit test (unless something was changed and it will fail consistently) https://github.com/kubevirt/ipam-extensions/actions/runs/10900433841/job/30248013978?pr=68 i think it is not related to this PR, as it changes only e2e

Hm, it's the order right ? Do we really need the order of this to be this static ?
If not, we can just use consist of instead of equal in the tests.
@qinqon

@qinqon
Copy link
Collaborator

qinqon commented Sep 18, 2024

interesting, flake on unit test (unless something was changed and it will fail consistently) https://github.com/kubevirt/ipam-extensions/actions/runs/10900433841/job/30248013978?pr=68 i think it is not related to this PR, as it changes only e2e

Hm, it's the order right ? Do we really need the order of this to be this static ? If not, we can just use consist of instead of equal in the tests. @qinqon

We are not crafting the jsonpatch ourselves, we just pass new and old pods to admission.PatchResponseFromRaw so this is supose to be fine, problem is that at slices order matter when we compare things at tests, even if we compare them as a json.

We have to fix the test so the test case instruct to ignore the order there.

@qinqon qinqon merged commit 0faf4cb into kubevirt:main Sep 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants