Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor monitoring metrics #786

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Refactor monitoring metrics #786

merged 1 commit into from
Jan 12, 2024

Conversation

machadovilaca
Copy link
Member

@machadovilaca machadovilaca commented Dec 19, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

none

jira-ticket: https://issues.redhat.com/browse/CNV-27458

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 19, 2023
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
@machadovilaca
Copy link
Member Author

/test all

@kubevirt-bot
Copy link
Contributor

@machadovilaca: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

/cc sradco

@github-actions GitHub Actions
Copy link

/cc sradco

@github-actions GitHub Actions
Copy link

/cc sradco

@machadovilaca
Copy link
Member Author

/test all

@kubevirt-bot
Copy link
Contributor

@machadovilaca: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

/cc sradco

@machadovilaca
Copy link
Member Author

/test ci/prow/unittests

@kubevirt-bot
Copy link
Contributor

@machadovilaca: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test ci/prow/unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2023

@machadovilaca: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-functests
  • /test e2e-single-node-functests
  • /test e2e-upgrade-functests
  • /test images
  • /test unittests
  • /test win10-pipeline-example-test
  • /test win11-pipeline-example-test
  • /test win2k22-pipeline-example-test

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-kubevirt-ssp-operator-main-e2e-functests
  • pull-ci-kubevirt-ssp-operator-main-e2e-single-node-functests
  • pull-ci-kubevirt-ssp-operator-main-e2e-upgrade-functests
  • pull-ci-kubevirt-ssp-operator-main-images
  • pull-ci-kubevirt-ssp-operator-main-unittests

In response to this:

/test ci/prow/unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machadovilaca
Copy link
Member Author

/test unittests

@kubevirt-bot
Copy link
Contributor

@machadovilaca: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test unittests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machadovilaca
Copy link
Member Author

/test all

@kubevirt-bot
Copy link
Contributor

@machadovilaca: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

/cc sradco

@kubevirt-bot
Copy link
Contributor

@machadovilaca: No presubmit jobs available for kubevirt/ssp-operator@main

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

/cc sradco

@machadovilaca machadovilaca marked this pull request as ready for review January 9, 2024 14:46
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2024
@github-actions GitHub Actions
Copy link

/cc sradco

@github-actions GitHub Actions
Copy link

/cc sradco

@machadovilaca
Refactor monitoring metrics
393170b 
Signed-off-by: João Vilaça <[email protected]>
@github-actions GitHub Actions
Copy link

/cc sradco

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@akrejcir
Copy link
Collaborator

Looks good.
Just a nit, can you remove the release note from the PR's description? Release note should contain information relevant for the user, and refactoring is usually invisible for users.

/lgtm

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 12, 2024
@machadovilaca
Copy link
Member Author

Looks good. Just a nit, can you remove the release note from the PR's description? Release note should contain information relevant for the user, and refactoring is usually invisible for users.

/lgtm

thanks, updated

@akrejcir
Copy link
Collaborator

/lgtm cancel

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@jcanocan
Copy link
Contributor

Great job! Thanks!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@kubevirt-bot kubevirt-bot merged commit a3ecf53 into kubevirt:main Jan 12, 2024
12 of 13 checks passed
@machadovilaca machadovilaca deleted the refactor-monitoring-metrics branch January 12, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@opokornyy opokornyy Awaiting requested review from opokornyy

@sradco sradco Awaiting requested review from sradco

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@akrejcir akrejcir

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@machadovilaca @kubevirt-bot @akrejcir @jcanocan