Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.19] Rename VirtualMachineCRCErrors to VMStorageClassWarning #886

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[release-v0.19] Rename VirtualMachineCRCErrors to VMStorageClassWarning #886

merged 1 commit into from
Feb 16, 2024

Conversation

machadovilaca
Copy link
Member

What this PR does / why we need it:

This is a manual cherry-pick of #875

jira-ticket: https://issues.redhat.com/browse/CNV-35099

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Rename VirtualMachineCRCErrors to VMStorageClassWarning

/cc @0xFelix @codingben @jcanocan

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 15, 2024
@github-actions GitHub Actions
Copy link

/cc sradco

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@akrejcir
Copy link
Collaborator

@machadovilaca the failing test in CI: [test_id:10549] Should fire VMStorageClassWarning when rxbounce is disabled is often flaky. Can you maybe investigate why? Not as part of this PR, but as a future PR.

@akrejcir
Copy link
Collaborator

/lgtm

@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@akrejcir
Copy link
Collaborator

/retest

@kubevirt-bot kubevirt-bot merged commit a3ec5cd into kubevirt:release-v0.19 Feb 16, 2024
12 checks passed
@akrejcir
Copy link
Collaborator

@machadovilaca the jira is for 4.14, so this PR should also be backported to release-v0.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingben codingben codingben approved these changes

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@jcanocan jcanocan Awaiting requested review from jcanocan

@sradco sradco Awaiting requested review from sradco

Assignees

@akrejcir akrejcir

@codingben codingben

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadovilaca @jcanocan @akrejcir @kubevirt-bot @codingben