Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OCI capability to fetch image manifest and configuration. #66

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Jul 1, 2024

Description

Adds a new OCI capability to allow policy authors to fetch container image manifest, digest and image configuration in a single host call.

Fix #53

Test

make e2e-test

@jvanz jvanz requested review from fabriziosestito, viccuad and a team July 1, 2024 20:57
@jvanz jvanz self-assigned this Jul 1, 2024
@jvanz jvanz added the kind/enhancement New feature or request label Jul 1, 2024
Copy link
Contributor

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some changes needed

internal/cel/library/oci.go Outdated Show resolved Hide resolved
internal/cel/library/oci.go Outdated Show resolved Hide resolved
e2e.bats Outdated Show resolved Hide resolved
Copy link
Contributor

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just few nitpicks and then we can :shipit:

@jvanz
Copy link
Member Author

jvanz commented Jul 2, 2024

Sorry, I've forgot to update the docs. Fixed!

Adds a new OCI capability to allow policy authors to fetch container
image manifest, digest and image configuration in a single host call.

Signed-off-by: José Guilherme Vanz <[email protected]>
@jvanz jvanz merged commit c077420 into kubewarden:main Jul 2, 2024
5 checks passed
@jvanz jvanz deleted the issue53 branch July 2, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose OCI image config capability in the CEL policy
3 participants