Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement glob builtins #58

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Implement glob builtins #58

merged 1 commit into from
Sep 10, 2021

Conversation

ereslibre
Copy link
Member

@ereslibre ereslibre commented Sep 1, 2021

Fixes: #39

@ereslibre ereslibre added the area/rego Issue related with Rego/OPA/Gatekeeper integration label Sep 1, 2021
@ereslibre ereslibre force-pushed the glob-builtins branch 8 times, most recently from 9211e8b to a08547a Compare September 2, 2021 10:19
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question.

As a final note, this doesn't implement glob.match, hence we cannot close #39

crates/burrego/src/opa/builtins/glob.rs Outdated Show resolved Hide resolved
@ereslibre
Copy link
Member Author

ereslibre commented Sep 10, 2021

As a final note, this doesn't implement glob.match, hence we cannot close #39

We can close it, this is about glob builtins. #57 was targeting regex builtins, and in that case, that issue had References: instead of Fixes: to signal exactly that.

However, glob.quote_meta is the only builtin for the glob group, and we are good by closing #39 after this merges.

@ereslibre ereslibre merged commit e9e12eb into opa Sep 10, 2021
@ereslibre ereslibre deleted the glob-builtins branch September 10, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rego Issue related with Rego/OPA/Gatekeeper integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants