Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rfc): add policy group RFC #37

Merged

Conversation

fabriziosestito
Copy link
Contributor

@fabriziosestito fabriziosestito commented Jun 13, 2024

Description

Adds policy group RFC

Fixes #34

@fabriziosestito fabriziosestito changed the title docs(rfc): add group policis RFC docs(rfc): add group policies RFC Jun 13, 2024
@fabriziosestito fabriziosestito requested review from a team and jhkrug June 13, 2024 08:22
@fabriziosestito fabriziosestito self-assigned this Jun 13, 2024
@jvanz jvanz self-requested a review June 13, 2024 21:17
Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the first glace, it looks nice to me. But I would like to learn more about Rhai before my final opinion. I'll study a little bit more about it.

rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
@flavio flavio added this to the 1.14 milestone Jun 14, 2024
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the detailed work

rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
rfc/0020-group-policies.md Outdated Show resolved Hide resolved
Signed-off-by: Fabrizio Sestito <[email protected]>
@fabriziosestito fabriziosestito changed the title docs(rfc): add group policies RFC docs(rfc): add policy group RFC Jun 18, 2024
@fabriziosestito fabriziosestito force-pushed the rfc/0020-group-policies branch 2 times, most recently from 35a3ea2 to 1bb734d Compare June 18, 2024 11:21
rfc/0020-policy-group.md Outdated Show resolved Hide resolved
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Fabrizio Sestito <[email protected]>
@fabriziosestito fabriziosestito merged commit 310d9a1 into kubewarden:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: how to group multiple policies using logical operators
4 participants