Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(*): add proposal for enhance orm by nri #525

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Airren
Copy link
Contributor

@Airren Airren commented Mar 27, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

Leverage NRI to enhance ORM, thus avoiding intrusive modifications to upstream Kubernetes components. This facilitates synchronous configuration of QoS policies and seamless injection of environment variables

Which issue(s) this PR fixes:

#430

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.48%. Comparing base (2d6e0a3) to head (6914502).
Report is 67 commits behind head on main.

❗ Current head 6914502 differs from pull request most recent head 776b501. Consider uploading reports for the commit 776b501 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   55.52%   55.48%   -0.04%     
==========================================
  Files         552      552              
  Lines       59056    59415     +359     
==========================================
+ Hits        32788    32964     +176     
- Misses      22842    23011     +169     
- Partials     3426     3440      +14     
Flag Coverage Δ
unittest 55.48% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@caohe
Copy link
Member

caohe commented Mar 29, 2024

@Airren Thanks for your contribution! This proposal is very detailed and well thought out. Could you sign the CLA required by the community?

@Airren
Copy link
Contributor Author

Airren commented Apr 1, 2024

@Airren Thanks for your contribution! This proposal is very detailed and well thought out. Could you sign the CLA required by the community?

sure, I have finished the CLA signed.

@Airren Airren mentioned this pull request Apr 18, 2024
@Airren Airren force-pushed the nri-proposal branch 2 times, most recently from 6b541f5 to 67d02d3 Compare April 24, 2024 02:47
@caohe caohe added workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Apr 24, 2024
@waynepeking348 waynepeking348 merged commit 14a6c31 into kubewharf:main Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

7 participants