Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loadaware scheduler plugin and npd controller plugin #654

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

WangZzzhe
Copy link
Collaborator

@WangZzzhe WangZzzhe commented Jul 19, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

loadAware scheduler plugin:
schedule pod by NPD and SPD portrait metrics

npd controller indicator plugin:
fetch metrics from metrics server and patch aggregated data to NPD status

Special notes for your reviewer:

pr should be rebased after kubewharf/katalyst-api#94 and #633 merged

@WangZzzhe WangZzzhe force-pushed the dev/npd-loadaware-plugin branch 2 times, most recently from d86d580 to 2949fc3 Compare July 19, 2024 04:10
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 68.24074% with 343 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (29d4745) to head (7bdce6a).

Files Patch % Lines
...roller/npd/indicator-plugin/loadaware/loadaware.go 67.53% 111 Missing and 13 partials ⚠️
pkg/controller/npd/npd.go 66.16% 35 Missing and 10 partials ⚠️
...ntroller/npd/indicator-plugin/loadaware/handler.go 71.55% 20 Missing and 13 partials ⚠️
cmd/katalyst-controller/app/options/npd.go 50.00% 27 Missing ⚠️
pkg/controller/npd/npd_indicator.go 59.25% 16 Missing and 6 partials ⚠️
pkg/controller/npd/handler.go 31.03% 15 Missing and 5 partials ⚠️
...er/npd/indicator-plugin/loadaware/sorter/helper.go 56.81% 18 Missing and 1 partial ⚠️
...ontroller/npd/indicator-plugin/loadaware/helper.go 83.15% 15 Missing and 1 partial ⚠️
pkg/client/control/npd.go 47.36% 8 Missing and 2 partials ⚠️
...er/npd/indicator-plugin/loadaware/sorter/scorer.go 71.42% 3 Missing and 3 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   57.00%   57.04%   +0.04%     
==========================================
  Files         552      567      +15     
  Lines       52838    53918    +1080     
==========================================
+ Hits        30118    30756     +638     
- Misses      18941    19333     +392     
- Partials     3779     3829      +50     
Flag Coverage Δ
unittest 57.04% <68.24%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WangZzzhe WangZzzhe force-pushed the dev/npd-loadaware-plugin branch 3 times, most recently from 5545830 to 4375250 Compare July 19, 2024 06:22
@WangZzzhe WangZzzhe added the enhancement New feature or request label Jul 19, 2024
)

type NPDOptions struct {
NPDIndicatorPlugins []string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPDMetricsPlugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants