Skip to content

mem.eviction: adding some enhancements #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lubinszARM
Copy link
Contributor

What type of PR is this?

Enhancements

What this PR does / why we need it:

Many oncall channels need these enhancements

Which issue(s) this PR fixes:

Some optimizations for numa.mem.eviction & system.mem.eviction

Special notes for your reviewer:

None

@lubinszARM lubinszARM requested a review from luomingmeng as a code owner July 1, 2025 03:14
@lubinszARM lubinszARM force-pushed the dev/pr_mem_eviction branch 6 times, most recently from 5451f83 to 53f17cc Compare July 7, 2025 08:31
@lubinszARM lubinszARM force-pushed the dev/pr_mem_eviction branch from 53f17cc to 0075f77 Compare July 7, 2025 09:22
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 69.76744% with 26 lines in your changes missing coverage. Please review.

Project coverage is 61.69%. Comparing base (0b0409b) to head (3d9a63f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...t/evictionmanager/plugin/memory/system_pressure.go 60.00% 7 Missing and 3 partials ⚠️
...ent/evictionmanager/plugin/memory/numa_pressure.go 71.42% 7 Missing and 1 partial ⚠️
pkg/agent/evictionmanager/plugin/memory/helper.go 71.42% 3 Missing and 3 partials ⚠️
...amic/adminqos/eviction/memory_pressure_eviction.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   61.68%   61.69%           
=======================================
  Files         637      637           
  Lines       67640    67690   +50     
=======================================
+ Hits        41727    41761   +34     
- Misses      21779    21803   +24     
+ Partials     4134     4126    -8     
Flag Coverage Δ
unittest 61.69% <69.76%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lubinszARM lubinszARM force-pushed the dev/pr_mem_eviction branch from 038743c to c91a6df Compare July 9, 2025 09:18
@lubinszARM lubinszARM force-pushed the dev/pr_mem_eviction branch 4 times, most recently from 26ab93b to ad9df3a Compare July 10, 2025 09:00
luomingmeng
luomingmeng previously approved these changes Jul 10, 2025
@luomingmeng luomingmeng added workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review and removed workflow/merge-ready merge-ready: code is ready and can be merged labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants