Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ページの言語のチェックリストページのwcagの関連リンクを修正 #1511

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

daiHash
Copy link
Contributor

@daiHash daiHash commented Mar 5, 2025

課題・背景

やったこと

- ページの言語のチェックリストページのwcagの関連リンクが「達成基準 1.3.3: 感覚的な特徴を理解する」になっていましたので、リンクを修正しました

やらなかったこと

  • デザイン・レイアウトの変更

動作確認

  • 修正した内容のリンクテキストとリンク先が確認できれば問題ない
  • previewでもみれます

キャプチャ

Before After
https://smarthr.design/accessibility/check-list/lang/#h2-4 https://deploy-preview-1511--smarthr-design-system.netlify.app/accessibility/check-list/lang/#h2-4
wcagの関連リンクが「達成基準 1.3.3: 感覚的な特徴を理解する」 wcagの関連リンクが「ページの言語と一部分の言語を理解する」

@daiHash daiHash self-assigned this Mar 5, 2025
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 068973a
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/67c822068830a30008d544eb
😎 Deploy Preview https://deploy-preview-1511--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gamochan-smhr gamochan-smhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今まで気づきませんでした…!よさそうです!

Copy link
Contributor

@maiha2 maiha2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daiHash daiHash merged commit 661b6c8 into main Mar 5, 2025
5 checks passed
@daiHash daiHash deleted the fix-langauge-of-page-reference-links branch March 5, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants