docs(DatePicker): Story を見直し #5081
Merged
+220
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
s-sasaki-0529
commented
Nov 6, 2024
| parameters: { | ||
| chromatic: { forcedColors: 'active' }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
DatePicker の VRT はカレンダーをそれぞれ開かなきゃならない都合もあるので、pict とは別に現行の VRT を概ね踏襲してます。
s-sasaki-0529
commented
Nov 6, 2024
packages/smarthr-ui/src/components/DatePicker/stories/VRTDatePicker.stories.tsx
Outdated
Show resolved
Hide resolved
s-sasaki-0529
requested review from
oti and
yt-ymmt
and removed request for
a team
uknmr
reviewed
Nov 6, 2024
There was a problem hiding this comment.
よさそうだったんですが、最新のビルドで Chromatic がエラーを吐いていました。
https://react.dev/errors/130?invariant=130&args%5B%5D=undefined&args%5B%5D=
|
むむむ…。 main 取り込んだりして再実行促しときます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
#4949 の方針に沿って、DatePicker の Story を見直しました。
変更内容
確認方法
Storybook や Chromatic で確認してください。