Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AccordionPanelTrigger): disabled な装飾を追加 #5086

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(AccordionPanelTrigger): disabled な装飾を追加 #5086

wants to merge 2 commits into from
+14 −2

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Nov 8, 2024 •
edited
Loading

関連URL

https://smarthr.atlassian.net/browse/SHRUI-1193

概要

AccordionPanelTrigger に disabled を渡せるが装飾が存在しなかったため追加しました。
disabled 時の装飾は Button に寄せています。

変更内容

  • AccordionPanelTrigger が disabled の時の装飾を追加
  • Story を追加

確認方法

Storybook や Chromatic で確認してください。

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5086

commit: c249bc6

@uknmr uknmr requested a review from AtsushiM November 8, 2024 09:49
@uknmr uknmr marked this pull request as ready for review November 8, 2024 09:49
@uknmr uknmr requested a review from a team as a code owner November 8, 2024 09:49
@uknmr uknmr requested review from masa0527 and removed request for a team November 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtsushiM AtsushiM Awaiting requested review from AtsushiM

@masa0527 masa0527 Awaiting requested review from masa0527 masa0527 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uknmr