Issue #9: not printing the stars, watchers, created, updated, contributors and anonymous if they were not found #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated, contributors and anonymous if they were not found
|
I went to have a look at some edge cases to verify this, and the last one is causing some noise to me: yuting1214/bin (0 anonymous, 1 contributor) 
lifesinger/blog (no data) 
TamirlanRamazanov/webproject2 (1 anonymous, 0 contributors) 
mrsrimar22/android_kernel_xiaomi_sm6225 (no data about anonymous nor contributors even though it is not blocked? I'm confused): https://github.com/mrsrimar22/android_kernel_xiaomi_sm6225 
|
|
...because it is a fork |
|
...but there were some commits made by the owner, perhaps there is at least 1 contributor (mrsrimar22) ? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/gitxray/xrays/repository_xray.py:377 # I left an unnecesary empty line
This commit is related to the issue #9 . After the main fix for the identification of blocked repos was implemented, it was possible to identify some minor QA checks before printing certain values.