perf: Convert between 1D and 2D indices in a non-stupid way. #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before I was just concatenating all of the previous lines in the buffer in order to compute the right indices. This PR changes things to use builtin Vim functions which are hopefully much more performant.
kylechui
force-pushed
the
perf/editing-large-files
branch
from
00fc0d1 to
64eff1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I was just concatenating all of the previous lines in the buffer in order to compute the right indices. This PR changes things to use builtin Vim functions which are hopefully much more performant.
Should resolve #398