Mesh density multiplier #243
Conversation
added mesh density modifier
add probe_count multiplication
|
Is this already available? Could not fund in main branch (also I do use Crality Helper Script) |
| {% set detach_macro = kamp_settings.detach_macro | string %} # Pull detach probe command from _KAMP_Settings | ||
| {% set mesh_margin = kamp_settings.mesh_margin | float %} # Pull mesh margin setting from _KAMP_Settings | ||
| {% set fuzz_amount = kamp_settings.fuzz_amount | float %} # Pull fuzz amount setting from _KAMP_Settings | ||
| {% set mesh_density = kamp_settings.mesh_density | float %} # Pull mesh density setting from _KAMP_Settings |
There was a problem hiding this comment.
| {% set mesh_density = kamp_settings.mesh_density | float %} # Pull mesh density setting from _KAMP_Settings | |
| {% set mesh_density = kamp_settings.variable_mesh_density | float %} # Pull mesh density setting from _KAMP_Settings |
There was a problem hiding this comment.
I don’t think variable needs to be in there, it’s not required, and it also doesn’t match the other variables in the meshing macro. Appreciate the review though!
There was a problem hiding this comment.
I am not suggesting that the name of the variable is changed. The author has used different names in two places, so I was simply matching the other place. I agree with your statement though, so perhaps it is better to remove variable_ from the other one instead of adding it here.
There was a problem hiding this comment.
Or maybe I am just confused about how variables work, actually. Feel free to ignore x)
There was a problem hiding this comment.
There’s a pitfall here. If you have KAMP updating though the update manager in moonraker, the settings file that is copied to the main directory will not receive the new density variable. So when this is ran on an older setup that updated, it will fail. There will need to be a default value here of 1 initially, that will be overridden if the new variable is found in KAMP_Settings.cfg. You should also add some verbosity for this so the end user can verify that the correct density was applied.
Additionally, adaptive meshing is baked into stock klipper now, so KAMP’s meshing has pretty much been sunset. I don’t see a problem with adding this functionality though, it just needs to be done in a matter that won’t break working setups for those who don’t read the commit history. 😅
5 participants
I've added config for increasing probed mesh density. This might be useful for beds with great variability, or where small prints result in meshes that are not smooth enough.