-
Notifications
You must be signed in to change notification settings - Fork 202
Use bed_mesh bounds instead of hardcoded 0,0 for purge positioning #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7a37e7b to
75e4323
Compare
Signed-off-by: minicx <[email protected]>
75e4323 to
64b8807
Compare
|
I tried this with a test print of a square starting in the front left corner (x=10, y=10) and the purge line was connected to my print object. So it's quite working as expected. |
Signed-off-by: minicx <[email protected]>
Signed-off-by: minicx <[email protected]>
Fixed in the latest commit, thanks for testing! |
|
It still is connected and I guess it is because of the width of the purge line. The test objects starts at x=10 and this is the log of the purge line:
So for the script it is not overlapping but in reality it is. |
Is this a problem of pr? |
|
You're right. It's not a problem of your PR (So the last change is unnecessary). In my case |
In my opinion, for now it is better to setup kamp and purge through orca slicer, because klipper doesn't know what type of filament, diameter of nozzle currently used |
Use actual bed mesh min coordinates instead of hardcoded 0,0 to properly
position purge lines on printers with centered bed origins.