Add performance tests #1033
Add performance tests #1033
Conversation
|
Add one of following labels |
MarekMichali
force-pushed
the
stress-tests
branch
from
83ce161 to
3872947
Compare
docs/contributor/04-10-workflows.md
Outdated
|
|
||
| ### Performance Tests | ||
|
|
||
| The [workflow](/.github/workflows/run-performance-tests-reusable.yaml) runs performance and tests on the k3s cluster. The following parameters are required from the calling workflow: |
There was a problem hiding this comment.
runs performance and tests or just runs performance tests?
There was a problem hiding this comment.
Runs performance tests. I will fix it.
docs/contributor/04-10-workflows.md
Outdated
| - **Purpose**: Evaluates the system's response time and reconciliation success rate when the `sap-btp-manager` secret is updated frequently. | ||
| - **Steps**: | ||
| - Patches the `sap-btp-manager` secret in a loop to simulate frequent updates. | ||
| - Fetches metrics from the `btp-manager-controller-manager` to measure average reconcile time, reconcile errors, and other reconciliation statistics. |
There was a problem hiding this comment.
| - Fetches metrics from the `btp-manager-controller-manager` to measure average reconcile time, reconcile errors, and other reconciliation statistics. | |
| - Fetches metrics from `btp-manager-controller-manager` to measure average reconcile time, reconcile errors, and other reconciliation statistics. |
There was a problem hiding this comment.
Shouldn't reconcile time, reconcile errors be reconciliation time, reconciliation errors?
There was a problem hiding this comment.
I will change it to reconciliation.
There was a problem hiding this comment.
Please also change reconcile to reconciliation in the following lines: 122, 123, 133, 135, 136, and 141. And maybe line 128 - not sure if I get it right.
docs/contributor/04-10-workflows.md
Outdated
| - **Steps**: | ||
| - Patches the `sap-btp-manager` secret in a loop to simulate frequent updates. | ||
| - Fetches metrics from the `btp-manager-controller-manager` to measure average reconcile time, reconcile errors, and other reconciliation statistics. | ||
| - **Failure Handling**: |
There was a problem hiding this comment.
Failure Handling implies some information on how to cope with the failure, which is not the case here. How about:
The test fails in the following conditions:
- The average reconcile time exceeds the defined threshold.
- Some reconcile errors are detected.
There was a problem hiding this comment.
You are right. I will change it to The test fails in the following conditions
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Co-authored-by: Iwona Langer <[email protected]>
Description
Changes proposed in this pull request:
More details about the tests are in the documentation in the PR
Related issue(s)
See #1032