Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Create Service Binding Form #771

Closed
wants to merge 3 commits into from
Closed

Simple Create Service Binding Form #771

wants to merge 3 commits into from

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jul 24, 2024 •
edited
Loading

Description

The following PR contains a simple component for binding creation with a minimal set of fields that allow for binding creation.

Changes proposed in this pull request:

  • new ui/src/components/ServiceBindingForm.tsx component,
  • removed plural from ServiceInstanceBindings interface.

Related issue(s)

#442

@ralikio ralikio requested a review from a team as a code owner July 24, 2024 11:29
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2024
szwedm
szwedm previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 24, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2024
szwedm
szwedm previously approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 12, 2024
@szwedm
Copy link
Contributor

szwedm commented Aug 12, 2024

/test pull-btp-manager-build

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 12, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kyma-bot
Copy link
Contributor

@ralikio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-btp-manager-build 2008e53 link true /test pull-btp-manager-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ralikio
Copy link
Member Author

ralikio commented Aug 21, 2024

Duplicate

@ralikio ralikio closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm left review comments

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot