Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Bindings Value if No Content API Response #816

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 19, 2024

Description

Adjustment to changes introduced in https://github.com/kyma-project/btp-manager/pull/812/files#diff-5b9b550fff634f1fd5596893d63ceeb6afa6a355427db919a644a21f097b7834R200 that made API return no content for empty bindings lists.

Changes proposed in this pull request:

  • setting default service bindings list value when no-content API response received.

Related issue(s)

#442

@ralikio ralikio added the kind/bug Categorizes issue or PR as related to a bug. label Aug 19, 2024
@ralikio ralikio requested a review from a team as a code owner August 19, 2024 09:36
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 19, 2024
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@szwedm szwedm merged commit 84c1232 into kyma-project:sm-integration Aug 19, 2024
12 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants