Corrected Bindings List Refresh #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting delay attribute's value to 1 to minimize time needed for Busy indicator to appear.
Previously, when opening dialog for am instance with bindings before doing the same for an instance without bindings dialog kept data for the former one. Clearing instances and bindings list data prevents this behaviour.
Removed unnecessary `setLoading(false)` invocations not to turn BusyIndicator off too soon.
Display ObjectPageContent with additional top padding. Center busy indicator by setting its display property to `block`.
kyma-bot
added
cla: yes
ralikio
added
the
kind/enhancement
MarekMichali
approved these changes
Aug 21, 2024
szwedm
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Minimum Delay on Busy Indicator Setting delay attribute's value to 1 to minimize time needed for Busy indicator to appear. * Clearing Instance Between Dialog Reloads Previously, when opening dialog for am instance with bindings before doing the same for an instance without bindings dialog kept data for the former one. Clearing instances and bindings list data prevents this behaviour. * Corrected Loading State Removed unnecessary `setLoading(false)` invocations not to turn BusyIndicator off too soon. * Correct CSS for Object Page and Busy Indicator Display ObjectPageContent with additional top padding. Center busy indicator by setting its display property to `block`.
kyma-gopher-bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Minimum Delay on Busy Indicator Setting delay attribute's value to 1 to minimize time needed for Busy indicator to appear. * Clearing Instance Between Dialog Reloads Previously, when opening dialog for am instance with bindings before doing the same for an instance without bindings dialog kept data for the former one. Clearing instances and bindings list data prevents this behaviour. * Corrected Loading State Removed unnecessary `setLoading(false)` invocations not to turn BusyIndicator off too soon. * Correct CSS for Object Page and Busy Indicator Display ObjectPageContent with additional top padding. Center busy indicator by setting its display property to `block`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Details in commits descriptions.
Related issue(s)
#442