Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary Error #847

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Unnecessary Error #847

merged 4 commits into from
Aug 23, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 23, 2024

Description

Changes proposed in this pull request:

  • Removed error banner that added "no entries" message when any error occurs - such behaviour was unnecessary since error message has its place at the top of the table and it disabled rendering of existing instances after removal of one instance failed.

Related issue(s)

#442

@ralikio ralikio added the kind/bug Categorizes issue or PR as related to a bug. label Aug 23, 2024
@ralikio ralikio requested a review from a team as a code owner August 23, 2024 12:08
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2024
MarekMichali
MarekMichali previously approved these changes Aug 23, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 23, 2024
@ralikio ralikio dismissed MarekMichali’s stale review August 23, 2024 12:10

The merge-base changed after approval.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 23, 2024
@ralikio ralikio requested a review from MarekMichali August 23, 2024 12:10
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 23, 2024
@ralikio ralikio merged commit 8b9ac16 into kyma-project:sm-integration Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@MarekMichali MarekMichali

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @MarekMichali @kyma-bot