Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info on WatchParametersFromChanges #956

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Add info on WatchParametersFromChanges #956

merged 4 commits into from
Jan 13, 2025

Conversation

IwonaLanger
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add information on automatic update of service instances after changes to Secrets.

Related issue(s)
#955

@IwonaLanger IwonaLanger added documentation Improvements or additions to documentation area/documentation Issues or PRs related to documentation kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Jan 10, 2025
@IwonaLanger IwonaLanger requested a review from szwedm January 10, 2025 14:21
@IwonaLanger IwonaLanger self-assigned this Jan 10, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Jan 10, 2025
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2025
@IwonaLanger IwonaLanger removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@IwonaLanger IwonaLanger marked this pull request as ready for review January 13, 2025 10:05
@IwonaLanger IwonaLanger requested a review from a team as a code owner January 13, 2025 10:05
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 13, 2025 10:06
szwedm
szwedm approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 13, 2025
@IwonaLanger IwonaLanger changed the title Add a note on WatchParametersFromChanges Add info on WatchParametersFromChanges Jan 13, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit 38a2fb7 into kyma-project:main Jan 13, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

Assignees

@mmitoraj mmitoraj

@szwedm szwedm

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. documentation Improvements or additions to documentation kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IwonaLanger @mmitoraj @szwedm @kyma-bot @kyma-gopher-bot