feat(gcpnfsbackup): change AccessibleFrom to discriminated union struct#1723
Open
dushanpantic wants to merge 3 commits intokyma-project:mainfrom
Open
feat(gcpnfsbackup): change AccessibleFrom to discriminated union struct#1723dushanpantic wants to merge 3 commits intokyma-project:mainfrom
dushanpantic wants to merge 3 commits intokyma-project:mainfrom
Conversation
Contributor
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
019be50 to
e931632
Compare
stekik
previously approved these changes
Feb 27, 2026
stekik
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors
accessibleFromfield in GcpNfsVolumeBackup and GcpNfsBackupSchedule from[]stringwith magic"all"value to a discriminated union struct withtypeandtargetsfields.Motivation
The previous API used a magic string
"all"mixed with regular shoot IDs, which had several issues:"all"isn't combined with other values"all"a shoot name or a special keyword?The new design follows established Kubernetes API patterns where a
typefield discriminates behavior:type: ClusterIP|NodePort|LoadBalancerpathType: Exact|Prefix|ImplementationSpecificmetrics[].type: Resource|Pods|Object|ExternalChanges proposed in this pull request:
AccessibleFromstruct withTypeenum (All/Specific) andTargetsslicetargetsrequired whenSpecific, empty whenAllMigration
Before:
After:
Before:
After:
Related issue(s)