chore: eval test to release workflow #573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note(s) for PR Auther:
Note(s) for PR Reviewer(s):
|
friedrichwilken
changed the title
mfaizanse
reviewed
Jun 17, 2025
| @@ -38,7 +37,6 @@ on: | |||
| # global env variables. | |||
| env: | |||
| REPOSITORY_FULL_NAME: "${{ github.repository }}" # <owner>/<repository-name>. | |||
| IMAGE_NAME: "europe-docker.pkg.dev/kyma-project/prod/kyma-companion" # without tag. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
this is a draft and not ready for review.
mfaizanse
reviewed
Jun 17, 2025
| ## in the run-integration-test.yaml workflow as well. | ||
| name: Run evaluation tests | ||
| env: | ||
| IMAGE_NAME: "europe-docker.pkg.dev/kyma-project/prod/kyma-companion" # without tag. |
There was a problem hiding this comment.
this is without tag. At this stage in the pipeline, we have not build the image for the tag.
So, I think we can use the ref/sha to fetch status of build job of that commit, and use that tag to test.
There was a problem hiding this comment.
For example: europe-docker.pkg.dev/kyma-project/prod/kyma-companion:7ba3567babc5cb8c494a83dc4e291d14deee9666
There was a problem hiding this comment.
so,
- Get the SHA of head commit from release branch.
- Use the image
europe-docker.pkg.dev/kyma-project/prod/kyma-companion:<SHA>
You would need another job to compute the image name and export it as job output, to use it in with section. Example.
There was a problem hiding this comment.
this is a draft and not ready for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)