Skip to content

Regions support machine by provider #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

Regions support machine by provider #2098

merged 2 commits into from
Jun 12, 2025

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Jun 10, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • instead of having static RegionSupportingMachine instance for all providers - the RegionsSupportingMachine is always created as local variable (from the config by ProviderType), then used

Related issue(s)
Related: #1902

@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review June 11, 2025 09:57
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner June 11, 2025 09:57
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) June 11, 2025 09:57
@piotrmiskiewicz piotrmiskiewicz added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jun 11, 2025
szwedm
szwedm reviewed Jun 11, 2025
View reviewed changes
szwedm
szwedm reviewed Jun 11, 2025
View reviewed changes
@piotrmiskiewicz piotrmiskiewicz force-pushed the regions-support-machine-by-provider branch 2 times, most recently from 355e917 to 969939e Compare June 12, 2025 06:29
@piotrmiskiewicz piotrmiskiewicz force-pushed the regions-support-machine-by-provider branch from 969939e to 8fab2f3 Compare June 12, 2025 06:35
szwedm
szwedm approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-gopher-bot kyma-gopher-bot merged commit f5f3fe0 into kyma-project:main Jun 12, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrmiskiewicz @szwedm @kyma-gopher-bot