-
Notifications
You must be signed in to change notification settings - Fork 14
chore: Add Watcher Setup guide #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lindnerby
merged 13 commits into
kyma-project:main
from
lindnerby:add-watcher-setup-guide
Mar 11, 2025
Merged
chore: Add Watcher Setup guide #502
lindnerby
merged 13 commits into
kyma-project:main
from
lindnerby:add-watcher-setup-guide
Mar 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f15eaa8
to
89d5f6e
Compare
89d5f6e
to
1adb80a
Compare
5 tasks
mmitoraj
reviewed
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few suggestions. In addition could you:
- change the file name from "Listener.md" to lowercase: "listener.md"?
- change the file name "guide.md" to something more meaningful, for example, "configure-watcher.md" or "watcher-set-up-guide.md", etc.? Remember to update paths later on.
- See the local file with the suggestions for the guide itself :)
c-pius
reviewed
Mar 10, 2025
Co-authored-by: Małgorzata Świeca <[email protected]> Co-authored-by: Christoph Schwägerl <[email protected]>
Apply first technical writer review Co-authored-by: Małgorzata Świeca <[email protected]>
Sure, applied your suggestions @mmitoraj |
mmitoraj
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Issues or PRs related to documentation
lgtm
Looks good to me!
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)