Skip to content

chore: Add Watcher Setup guide #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 11, 2025

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Mar 3, 2025

Description

Changes proposed in this pull request:

  • Add a step-by-step guide for Kyma teams to setup the Watcher mechanism for their component
  • Re-structure and update listener pkg description

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/documentation Issues or PRs related to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2025
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2025
@LeelaChacha LeelaChacha force-pushed the add-watcher-setup-guide branch from f15eaa8 to 89d5f6e Compare March 5, 2025 08:28
@LeelaChacha LeelaChacha force-pushed the add-watcher-setup-guide branch from 89d5f6e to 1adb80a Compare March 5, 2025 08:30
@lindnerby lindnerby removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
@lindnerby lindnerby marked this pull request as ready for review March 7, 2025 08:29
@lindnerby lindnerby requested a review from a team as a code owner March 7, 2025 08:29
@lindnerby lindnerby changed the title feat: Add Watcher Setup guide chore: Add Watcher Setup guide Mar 7, 2025
Copy link
Contributor

@mmitoraj mmitoraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few suggestions. In addition could you:

  • change the file name from "Listener.md" to lowercase: "listener.md"?
  • change the file name "guide.md" to something more meaningful, for example, "configure-watcher.md" or "watcher-set-up-guide.md", etc.? Remember to update paths later on.
  • See the local file with the suggestions for the guide itself :)

@c-pius c-pius self-assigned this Mar 10, 2025
LeelaChacha and others added 4 commits March 10, 2025 15:36
Co-authored-by: Małgorzata Świeca <[email protected]>
Co-authored-by: Christoph Schwägerl <[email protected]>
Apply first technical writer review

Co-authored-by: Małgorzata Świeca <[email protected]>
@lindnerby
Copy link
Member Author

I've added a few suggestions. In addition could you:

  • change the file name from "Listener.md" to lowercase: "listener.md"?
  • change the file name "guide.md" to something more meaningful, for example, "configure-watcher.md" or "watcher-set-up-guide.md", etc.? Remember to update paths later on.
  • See the local file with the suggestions for the guide itself :)

Sure, applied your suggestions @mmitoraj
Please take a look

@lindnerby lindnerby enabled auto-merge (squash) March 10, 2025 19:57
@lindnerby lindnerby merged commit f2a564c into kyma-project:main Mar 11, 2025
10 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 11, 2025
@lindnerby lindnerby deleted the add-watcher-setup-guide branch March 11, 2025 07:09
@c-pius c-pius assigned lindnerby and unassigned c-pius and mmitoraj Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants