Skip to content

chore: Limit GH workflow permissions #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Feb 28, 2025

Description

Changes proposed in this pull request:

  • removes the permissions from all GH workflows except for the ones explicitly requiring permissions, those limited to the minimum
    • permissions: { } disables all permissions for the workflow
  • changes PR Title Lint from pull_request_target to pull_request

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner February 28, 2025 13:35
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 28, 2025
@c-pius c-pius merged commit ec2f769 into kyma-project:main Mar 3, 2025
12 checks passed
@c-pius c-pius deleted the chore/limit-workflow-permissions branch March 3, 2025 07:36
LeelaChacha pushed a commit to LeelaChacha/kyma-template-operator that referenced this pull request May 15, 2025
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.
-->

**Description**

Changes proposed in this pull request:

- removes the permissions from all GH workflows except for the ones
explicitly requiring permissions, those limited to the minimum
  - `permissions: { }` disables all permissions for the workflow
- changes PR Title Lint from `pull_request_target` to `pull_request`

**Related issue(s)**
<!-- If you refer to a particular issue, provide its number. For
example, `Resolves kyma-project#123`, `Fixes kyma-project#43`, or `See also kyma-project#33`. -->

- closes kyma-project/lifecycle-manager#2263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check required permissions for GH actions
3 participants