-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kube): add required interactivemode for exec #2264
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Christopher Haar <[email protected]>
c955c7f
to
02f4928
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
=======================================
Coverage 67.47% 67.47%
=======================================
Files 148 148
Lines 6518 6519 +1
=======================================
+ Hits 4398 4399 +1
Misses 1875 1875
Partials 245 245 ☔ View full report in Codecov by Sentry. |
something is missing to get this merged ? |
@eddycharly any chance for review and cut a new fix release ? |
Signed-off-by: Christopher Haar <[email protected]>
its unrelated to this PR - this is because of the main branch merge from @JimBugwadia - @VedRatan i updated the linter list - can you give it a try an approve the workflow run ? |
@VedRatan @JimBugwadia any change to get an workflow approval ? |
@eddycharly @realshuting @vishal-chdhry @MariamFahmy98 can anyone of you approve the workflows ? So that we can move ahead with the PR ? |
linter works now - but failing unrelated |
Hi, if someone on Nirmata's side can approve the PR so we can merge it, that'd be greatly appreciated from Upbound's side. Seems like the changes Chris is making now are unrelated linter changes to the original PR. |
Explanation
when using kubeconfig with exec providers and
client.authentication.k8s.io/v1
we fix the following issue:interactiveMode must be specified for chainsaw to use exec authentication plugin
If APIVersion is client.authentication.k8s.io/v1alpha1 or client.authentication.k8s.io/v1beta1, then this field is optional and defaults to "IfAvailable" when unset. Otherwise, this field is required.
Related issue
#2263
Proposed Changes
add interactiveMode IfAvailable
Checklist
Further Comments