Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kube): add required interactivemode for exec #2264

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

haarchri
Copy link

Explanation

when using kubeconfig with exec providers and client.authentication.k8s.io/v1 we fix the following issue:
interactiveMode must be specified for chainsaw to use exec authentication plugin

If APIVersion is client.authentication.k8s.io/v1alpha1 or client.authentication.k8s.io/v1beta1, then this field is optional and defaults to "IfAvailable" when unset. Otherwise, this field is required.

Related issue

#2263

Proposed Changes

add interactiveMode IfAvailable

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.

Further Comments

@haarchri haarchri requested a review from a team as a code owner January 14, 2025 18:49
@haarchri haarchri force-pushed the fix/kube-exec-interactive-mode branch from c955c7f to 02f4928 Compare January 14, 2025 18:49
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.47%. Comparing base (57a4201) to head (3a2fff4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2264   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files         148      148           
  Lines        6518     6519    +1     
=======================================
+ Hits         4398     4399    +1     
  Misses       1875     1875           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haarchri
Copy link
Author

something is missing to get this merged ?

@haarchri
Copy link
Author

haarchri commented Feb 4, 2025

@eddycharly any chance for review and cut a new fix release ?

@VedRatan
Copy link

@haarchri you need to fix lint, it seems like some of the linters are outdated completely, you need to replace these outdated linters with the new linters as mentioned here

@haarchri
Copy link
Author

its unrelated to this PR - this is because of the main branch merge from @JimBugwadia - @VedRatan i updated the linter list - can you give it a try an approve the workflow run ?

@haarchri
Copy link
Author

haarchri commented Mar 3, 2025

@VedRatan @JimBugwadia any change to get an workflow approval ?

@VedRatan
Copy link

VedRatan commented Mar 3, 2025

@eddycharly @realshuting @vishal-chdhry @MariamFahmy98 can anyone of you approve the workflows ? So that we can move ahead with the PR ?

@haarchri
Copy link
Author

haarchri commented Mar 3, 2025

linter works now - but failing unrelated

@hl782
Copy link

hl782 commented Mar 3, 2025

Hi, if someone on Nirmata's side can approve the PR so we can merge it, that'd be greatly appreciated from Upbound's side. Seems like the changes Chris is making now are unrelated linter changes to the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants