fix: handle existing resources gracefully in create operation #2351 #2353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash01ish
force-pushed
the
fix-stale-resource-cleanup
branch
from
ff40554 to
51cc5af
Compare
ash01ish
changed the title
…#2351 When a test exits unexpectedly after creating resources, those resources aren't cleaned up. When the test is run again, it detects the existing resources but returns an error instead of cleaning them up, leaving them stale indefinitely. This change modifies the tryCreateResource method to not return an error when a resource already exists, but instead continue with the operation. This ensures that pre-existing resources are properly cleaned up at the end of the test. Fixes kyverno#2351 Signed-off-by: Ashish Thirunagari <[email protected]>
ash01ish
force-pushed
the
fix-stale-resource-cleanup
branch
from
51cc5af to
f7bc1a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test exits unexpectedly after creating resources, those resources aren't cleaned up. When the test is run again, it detects the existing resources but returns an error instead of cleaning them up, leaving them stale indefinitely.
This change modifies the tryCreateResource method to not return an error when a resource already exists, but instead continue with the operation. This ensures that pre-existing resources are properly cleaned up at the end of the test.
Fixes #2351
Explanation
Related issue
Proposed Changes
Checklist
Further Comments