feat: Create Splunk target implementation and CRD #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who want to consume the splunk target will need to use splunk HTTP Event Collector (HEC) in their instances Signed-off-by: aerosouund <[email protected]>
Signed-off-by: aerosouund <[email protected]>
Pull Request Test Coverage Report for Build 14067215543Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: aerosouund <[email protected]>
fjogeleit
reviewed
Mar 25, 2025
pkg/target/factory/factory.go
Outdated
| @@ -827,6 +870,14 @@ func (f *TargetFactory) mapSecretValues(config any, ref, mountedSecret string) { | |||
| c.Config.Channel = values.Channel | |||
| } | |||
|
|
|||
| case *v1alpha1.Config[v1alpha1.SplunkOptions]: | |||
| if values.Webhook != "" { | |||
There was a problem hiding this comment.
You are checking for Webhook and setting Host, you should adopt test cases for splunk to ensure its working
|
Splunk should also support a batch API, you could also implement the BatchSend API in this case. |
- Add the splunk creation method in the factory interface - fix MapConfigTargets function typo - map splunk to a target from the config file - test secret mapping for splunk - implement batch send api on splunk Signed-off-by: aerosouund <[email protected]>
Signed-off-by: aerosouund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who want to consume the splunk target will need to use splunk HTTP Event Collector (HEC) in their instances