Skip to content

removed devguard.org link and moved to frontend to make it clickable #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

removed devguard.org link and moved to frontend to make it clickable #929

merged 1 commit into from
Jul 22, 2025

Conversation

5byuri
Copy link
Member

@5byuri 5byuri commented Jul 21, 2025

@5byuri
Copy link
Member Author

5byuri commented Jul 21, 2025

image now the TOS is clickable

@timbastin
Copy link
Member

Are you sure you committed everything? I only see a single change in the identity schema

@5byuri
Copy link
Member Author

5byuri commented Jul 21, 2025

Yes!
Ory uses the change-identity.schema, as of right now we have devguard.org/terms-of-use actually in the title.
https://github.com/l3montree-dev/devguard-web/blob/main/src/components/kratos/NodeInputCheckbox.tsx
I moved the link to the frontend and made it clickable with an anchor.

@5byuri
Copy link
Member Author

5byuri commented Jul 21, 2025

if we dont change the json, it would look like this:
image

@seb-kw seb-kw merged commit d61305d into main Jul 22, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seb-kw seb-kw seb-kw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@5byuri @timbastin @seb-kw