#31 #44
#31 #44
Conversation
|
@l3r8yJ could you review this? |
src/main/kotlin/ru/l3r8y/springxrolesauthoritiesstarter/filter/XRolesAuthenticationFilter.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/ru/l3r8y/springxrolesauthoritiesstarter/filter/XRolesAuthenticationFilter.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/ru/l3r8y/springxrolesauthoritiesstarter/filter/XRolesAuthenticationFilter.kt
Outdated
Show resolved
Hide resolved
|
|
||
| @SpringBootApplication | ||
| public class TestApplication { | ||
| open class TestApplication |
There was a problem hiding this comment.
@PavelRyauzov open here is redundant, apply plugin to all classes, please
There was a problem hiding this comment.
I was inattentive, fixed it
| val registration = FilterRegistrationBean(XRolesAuthenticationFilter()) | ||
| registration.order = SecurityProperties.DEFAULT_FILTER_ORDER | ||
| return registration |
There was a problem hiding this comment.
@PavelRyauzov try this
return FilterRegistrationBean(XRolesAuthenticationFilter()).apply {
this.order = SecurityProperties.DEFAULT_FILTER_ORDER
}There was a problem hiding this comment.
cool, it looks more elegant, fixed this
| class XRolesAuthenticationFilter : OncePerRequestFilter() { | ||
|
|
||
| private companion object { | ||
| private const val X_ROLES_HEADER = "X-Roles" |
There was a problem hiding this comment.
@PavelRyauzov when companion object is private there is no need to make it members private, as far as i know. Double check this one please
There was a problem hiding this comment.
I checked, you were right, fixed this
| val header = request.getHeader(X_ROLES_HEADER) | ||
| header ?: run { | ||
| chain.doFilter(request, response) | ||
| return | ||
| } |
There was a problem hiding this comment.
@PavelRyauzov try this
val header = request.getHeader(X_ROLES_HEADER) ?: run { chain.doFilter(request, response); return }| val authorized = SecurityContextHolder.getContext().authentication | ||
| authorized ?: run { | ||
| chain.doFilter(request, response) | ||
| return | ||
| } |
| authorized.credentials, | ||
| authorities | ||
| ) | ||
| SecurityContextHolder.getContext().authentication = withXRoles |
There was a problem hiding this comment.
@PavelRyauzov try this
SecurityContextHolder.getContext().apply {
this.authentication = withXRoles
}
|
@PavelRyauzov fix CI please, run |
|
@PavelRyauzov some news? |
|
@l3r8yJ done, fixed xml |
| @@ -62,6 +62,8 @@ SOFTWARE. | |||
| </ciManagement> | |||
| <properties> | |||
| <java.version>17</java.version> | |||
| <kotlin.version>1.9.22</kotlin.version> | |||
There was a problem hiding this comment.
@PavelRyauzov lets use latest version of Kotlin?
closes #31
PR-Codex overview
This PR focuses on migrating Java code to Kotlin, enhancing the codebase's conciseness and readability while maintaining functionality. It also introduces a new
XRolesAuthenticationFilterand updates endpoint handling with Kotlin's syntax.Detailed summary
XRolesAuthenticationFilter.java.TestApplication.javatoTestApplication.kt.Endpoints.javatoEndpoints.kt, changing method signatures and authorization logic.Config.javatoConfig.kt, simplifying security configuration.XRolesAuthenticationFilter.ktwith custom filtering logic.EndpointsTest.javatoEndpointsTest.kt, updating test method signatures and assertions.pom.xmlto include Kotlin dependencies and configuration.pom.xml.