Fix memory leak: clear stale metrics for each zone/account before fetching #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes what I believe to be a serious memory leak in the cloudflare-exporter. On a system scraping a significant amount of metrics with nearly 100 zones, the memory consumption of the exporter gradually increases to the point of exhaustion.
This PR implements a simple fix which clears the accumulated metrics before the next scrape. However it's careful to only clear them for the target zone/account, to ensure unprocessed metrics for a different zone/account aren't lost.
From my tests so far, the results are quite promising as the exporter is much more stable now - not showing an increase in memory consumption beyond what one would consider "normal".