Use pinned dependencies for testing #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've now duplicated the tests: they will run once with pinned deps, and once without. My intention is to make it easy to spot failures due to updates in dependencies, while also making it possible to separate out fixes due to updates in dependencies (often changes in mypy or ruff) from the content of particular MRs. I've also deleted requirements.txt as it wasn't being used.
I'm removing Python 3.9 from the tests as it's now really quite old.
I think this is due to a ruff update. This PR should make these sort of changes easier to separate out.
Currently, only editable installs can validate Thing Descriptions. This should be fixed and is raised as #97
This has appeared as a result of changes to either mypy or numpy. These types are a bit ugly, but do work as needed. Improvement in the future would be very nice.
Barecheck - Code coverage reportTotal: 81.55%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
pip install -e .[dev,server]to set up the Python environment in CI. This means that, ifrufformypy(or indeed anything else) updates, it might cause the CI to fail. This then means fixes end up in random PRs, because otherwise the CI fails for those PRs. I am now using pinned dependencies as per usual best practice.I've duplicated the tests rather than just pinning them: tests will run once with pinned deps, and once without. Testing without pinned dependencies helps spot issues people might run into if they just
pip installthe package, as most users would do. In the future, this should probably use the exact commands in thequickstartsection.This PR also updates the upload-artifact CI step to use v4, as v3 is now no longer supported.
I've also deleted requirements.txt as it wasn't being used.