Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a ViSP implementation of Canny edge detector #1215

Merged
merged 10 commits into from
Aug 30, 2023

Conversation

rolalaro
Copy link

Implemented a ViSP version of the Canny edge detector that does not rely on OpenCV imgproc

@fspindle
Copy link
Contributor

Ready to merge when ci ok

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 12.22% and project coverage change: -0.23% ⚠️

Comparison is base (83555f3) 54.98% compared to head (4c258eb) 54.75%.

❗ Current head 4c258eb differs from pull request most recent head ad4cbc7. Consider uploading reports for the commit ad4cbc7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
- Coverage   54.98%   54.75%   -0.23%     
==========================================
  Files         399      401       +2     
  Lines       49201    49398     +197     
==========================================
- Hits        27051    27047       -4     
- Misses      22150    22351     +201     
Files Changed Coverage Δ
...les/core/include/visp3/core/vpCannyEdgeDetection.h 0.00% <0.00%> (ø)
modules/core/src/image/vpCannyEdgeDetection.cpp 0.00% <0.00%> (ø)
modules/core/src/image/vpImageFilter.cpp 63.82% <66.66%> (ø)
modules/core/include/visp3/core/vpImageFilter.h 92.36% <92.85%> (-0.03%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit d6e64de into lagadic:master Aug 30, 2023
38 of 56 checks passed
@rolalaro rolalaro deleted the vpCanny branch October 5, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants