-
Notifications
You must be signed in to change notification settings - Fork 293
RBT: JSON Schema validation and explanation #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SamFlt
wants to merge
10
commits into
lagadic:master
Choose a base branch
from
SamFlt:rbt_json_explainable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
- Coverage 54.48% 54.48% -0.01%
==========================================
Files 442 442
Lines 53449 53449
==========================================
- Hits 29123 29122 -1
- Misses 24326 24327 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…and description in one go
…t_json_explainable
…ication and description in one go" This reverts commit 5675b19.
fspindle
added a commit
to SamFlt/visp
that referenced
this pull request
Apr 2, 2025
… and that can't be set in the json file There is something weird in the test: - mu seems no more an array in PR lagadic#1631 - there should be a muIterFactor var as given in PR lagadic#1631 "mu": { "description": "The initial value for the regularization parameter of the LM algorithm.This value is multiplied by muIterfactor at every iteration.A low value of mu leads to a Gauss Newton minimizer, while a higher value is closer to a gradient descent solution.", "exampleValue": 0.1, "required": true, "type": "double" }, "muIterFactor": { "description": "The factor with which to multiply the current regularization parameter value.", "exampleValue": 0.1, "required": true, "type": "double" },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to include a cleaner JSON parsing and validation for the RBT Json configuration.
This is done through a base class
vpRBJsonParsable
which has three methods: schema parsing, verification and explanation. Explanation is used to describe every possible parameter for a given object, and indicates whether a given parameter is required or not.An advantage of this solution is that the explanation document can be used to generate an HTML version of the documentation as well as give an on the fly explanation when the user gives an incorrect parameter.
For tracker features and other interchangeable RBT parts, a list of options is given.
This is an incomplete example of a full explanation of the RBT Tracker parameters: