Skip to content

Adding optional mask in plane estimation from point cloud #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Jun 2, 2025

This PR proposes to add an optional mask to the vpPlaneEstimation::estimatePlane method.
The mask is a std::optional<vpImage> that can either be given to the method to ignore some points of the point cloud or be set to nullopt to consider all the points in the RoI (if any) or in the image

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (67998e4) to head (1a55cf6).
Report is 106 commits behind head on master.

Files with missing lines Patch % Lines
.../vision/src/plane-estimation/vpPlaneEstimation.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   54.63%   54.63%   -0.01%     
==========================================
  Files         447      447              
  Lines       54389    54393       +4     
==========================================
  Hits        29717    29717              
- Misses      24672    24676       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fspindle fspindle merged commit 8c4c8f3 into lagadic:master Jun 10, 2025
74 checks passed
@rolalaro rolalaro deleted the feat_plane_estimation branch June 10, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants