-
Notifications
You must be signed in to change notification settings - Fork 36
[WIP] feature sample functions #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@davidlghellin Yep! You're on the right track. Check out how alias is dealt with in other places in the code base though. It is a little unintuitive. |
I think I have made some progress, I do not know if the approach is correct, I thought about adding the random column and then make the filter with that column, what I do not know is then how I will raise the rest or if I have to refocus everything, but I'm watching and learning a lot. |
hello again I think I have made some progress, but I still have some doubts:
Thanks |
@davidlghellin Nice progress! Yeah setting up the tests will be really important to get you going. These instructions can help get you setup with the Spark tests: |
Would you mind trying on the host? Devcontainer is a new addition to our repo and we haven't validated the entire development process yet. It seems to me that your build takes much longer than we usually expect (> 3 hours vs 30 minutes). I suspect that the container may not have enough resources or there is some performance issue due to CPU architecture mismatch. Or if you have more detailed error messages, we'd be happy to take a closer look. |
ok, thanks, I will prepare a laptop for it, so I can retake debian with awesome or try nixOS. |
445f8fd
to
282c193
Compare
282c193
to
e79ea11
Compare
🚧 Draft PR
Hi 🙂 This is a draft PR to check if I understood the issue correctly.
I wanted to confirm if these would be the right steps to follow.
If it makes sense, I’ll continue working in this direction.
Thanks for the feedback — and sorry if this wasn’t the right issue 😅
#474