Skip to content

[WIP] feature sample functions #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

davidlghellin
Copy link
Contributor

@davidlghellin davidlghellin commented May 24, 2025

🚧 Draft PR

Hi 🙂 This is a draft PR to check if I understood the issue correctly.

I wanted to confirm if these would be the right steps to follow.
If it makes sense, I’ll continue working in this direction.

Thanks for the feedback — and sorry if this wasn’t the right issue 😅

#474

@davidlghellin davidlghellin marked this pull request as draft May 24, 2025 21:59
@shehabgamin
Copy link
Contributor

@davidlghellin Yep! You're on the right track. Check out how alias is dealt with in other places in the code base though. It is a little unintuitive.

@davidlghellin
Copy link
Contributor Author

I think I have made some progress, I do not know if the approach is correct, I thought about adding the random column and then make the filter with that column, what I do not know is then how I will raise the rest or if I have to refocus everything, but I'm watching and learning a lot.
For the moment there are some values to pinch.

Thanks
image

@davidlghellin
Copy link
Contributor Author

hello again

I think I have made some progress, but I still have some doubts:

  • The random I use I don't know if it's the appropriate one and it's vectorized.
  • I still have to try and see how to launch or use the tests for the function
  • For the part with replacement, I have to see how to generate random with the Poisson function.

Thanks

@shehabgamin
Copy link
Contributor

@davidlghellin Nice progress! Yeah setting up the tests will be really important to get you going.

These instructions can help get you setup with the Spark tests:
https://docs.lakesail.com/sail/latest/development/spark-tests/

@davidlghellin
Copy link
Contributor Author

Hi again,
I am trying to set up the tests and I have not been able to compile, apart from the time it has failed.
image
I tried in devcontainer
I don't know if there is any option to download the jars and not have to compile, or that option is not viable.
I hope to find the time and try again
Thanks

@linhr
Copy link
Contributor

linhr commented May 28, 2025

Would you mind trying on the host? Devcontainer is a new addition to our repo and we haven't validated the entire development process yet. It seems to me that your build takes much longer than we usually expect (> 3 hours vs 30 minutes). I suspect that the container may not have enough resources or there is some performance issue due to CPU architecture mismatch.

Or if you have more detailed error messages, we'd be happy to take a closer look.

@davidlghellin
Copy link
Contributor Author

ok, thanks, I will prepare a laptop for it, so I can retake debian with awesome or try nixOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants