Skip to content

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Oct 14, 2025

Motivation

Description

Closes #issue_number

@github-actions github-actions bot added the L1 Ethereum client label Oct 14, 2025
Copy link

github-actions bot commented Oct 14, 2025

Lines of code report

Total lines added: 1373
Total lines removed: 11
Total lines changed: 1384

Detailed view
+---------------------------------------------------------------+-------+-------+
| File                                                          | Lines | Diff  |
+---------------------------------------------------------------+-------+-------+
| ethrex/cmd/ethrex/cli.rs                                      | 532   | +8    |
+---------------------------------------------------------------+-------+-------+
| ethrex/cmd/ethrex/initializers.rs                             | 413   | +4    |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/store.rs                                | 1440  | +10   |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/store_db/mod.rs                         | 5     | +2    |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/store_db/rocksdb.rs                     | 1102  | -11   |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/store_db/rocksdb_transactional.rs       | 1116  | +1116 |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/trie_db/mod.rs                          | 8     | +4    |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/trie_db/rocksdb_transactional.rs        | 165   | +165  |
+---------------------------------------------------------------+-------+-------+
| ethrex/crates/storage/trie_db/rocksdb_transactional_locked.rs | 64    | +64   |
+---------------------------------------------------------------+-------+-------+

@lferrigno
Copy link
Contributor

The code currently copy-pastes the Store implementation because making it generic would basically require some magic.

This should get much simpler once one of the following happens:

⚠️ Note: any merge from main should manually readjust the Store copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants