wip(l1): alternate snapshot calculation #4884
Draft
+358
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 175de2d.
Benchmark for 02a5733Click to view benchmark
|
Benchmark for 781ab2fClick to view benchmark
|
Benchmark for 8c91fc8Click to view benchmark
|
Benchmark for bb899daClick to view benchmark
|
Benchmark for f78d0a8Click to view benchmark
|
Benchmark for d88bcb2Click to view benchmark
|
pablodeymo
reviewed
Oct 16, 2025
crates/storage/store_db/in_memory.rs
Outdated
| } | ||
|
|
||
| fn generate_snapshot(&self) -> Result<(), StoreError> { | ||
| todo!() |
There was a problem hiding this comment.
relace this todo! for a Ok(()).
pablodeymo
reviewed
Oct 16, 2025
crates/storage/store_db/rocksdb.rs
Outdated
| const CF_INVALID_ANCESTORS: &str = "invalid_ancestors"; | ||
|
|
||
| #[derive(Debug)] | ||
| const CF_SNAPSHOTS: &str = "snapshots"; |
There was a problem hiding this comment.
we can use a better name for this CF. For example: flatkeyvalue
pablodeymo
reviewed
Oct 16, 2025
crates/storage/store_db/rocksdb.rs
Outdated
| let store_clone = store.clone(); | ||
| std::thread::spawn(move || { | ||
| let mut rx = rx; | ||
| while rx.recv() != Ok(SnapshotControlMessage::Continue) {} |
There was a problem hiding this comment.
we should take in account Err results of this call.
pablodeymo
reviewed
Oct 16, 2025
crates/storage/store_db/rocksdb.rs
Outdated
Comment on lines
478
to
479
| self.db | ||
| .delete_range_cf(&cf_snapshot, vec![], vec![0xff; 131])?; |
There was a problem hiding this comment.
this delete should be done after snap sync, not before
pablodeymo
reviewed
Oct 16, 2025
crates/storage/store_db/rocksdb.rs
Outdated
| .map(|v| Nibbles::from_hex(v.to_vec())) | ||
| .unwrap_or_default(); | ||
|
|
||
| println!("Starting snapshooting loop pivot={last_written:?} SR={state_root:x}"); |
Benchmark for 741e9baClick to view benchmark
|
Benchmark for 1ada7d2Click to view benchmark
|
Benchmark for 18ae5ffClick to view benchmark
|
edg-l
reviewed
Oct 17, 2025
| batch.put_cf(&cf_misc, "last_written", path.as_ref()); | ||
| batch.put_cf(&cf_snapshot, path.as_ref(), node.value); | ||
| ctr += 1; | ||
| if ctr > 10_000 { |
There was a problem hiding this comment.
i think its possible to miss a db.write if the last loop doesnt land on a > 10_000, i.e ctr < 10_000 and we dont loop anymore, isnt the batch lost?, i dont see any other db.write outsdie a if ctr > 10_000 to handle that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #issue_number