-
Notifications
You must be signed in to change notification settings - Fork 110
ci(l1,l2): avoid running L1 and L2 workflows on docs editing #4909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Avoid running L1/L2 CI workflows for documentation-only changes and add a new documentation page for recommended lectures.
- Add Recommended lectures page and link it in the docs sidebar.
- Update L2 (TDX build and prover) and L1 PR workflows to ignore docs changes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
docs/SUMMARY.md | Adds a sidebar link to the new Recommended lectures page. |
docs/LECTURES.md | Introduces a new docs page with curated lecture links. |
.github/workflows/pr-main_l2_tdx_build.yaml | Skips workflow on PRs that only change files under docs/**. |
.github/workflows/pr-main_l2_prover.yaml | Skips workflow on PRs that only change files under docs/**. |
.github/workflows/pr-main_l1.yaml | Skips workflow on PRs that only change files under docs/**. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
branches: ["main"] | ||
pull_request: | ||
branches: ["**"] | ||
|
||
paths-ignore: | ||
- "docs/**" # Documentation changes don't need to run the full workflow |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs-only commits pushed to main will still trigger this workflow because paths-ignore is only configured for pull_request. To fully avoid running on documentation-only edits, also add paths-ignore under push.
Copilot uses AI. Check for mistakes.
branches: ["main"] | ||
pull_request: | ||
branches: ["**"] | ||
paths-ignore: | ||
- "docs/**" # Documentation changes don't need to run the full workflow |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs-only commits pushed to main will still trigger this workflow because paths-ignore is only configured for pull_request. Mirror the ignore rule under push to prevent unnecessary runs on documentation-only changes.
Copilot uses AI. Check for mistakes.
Avoid running L1 and L2 workflows on docs editing