Skip to content

Conversation

lferrigno
Copy link
Contributor

Avoid running L1 and L2 workflows on docs editing

@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Oct 16, 2025
@lferrigno lferrigno marked this pull request as ready for review October 16, 2025 20:56
@lferrigno lferrigno requested a review from a team as a code owner October 16, 2025 20:56
@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 20:56
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Avoid running L1/L2 CI workflows for documentation-only changes and add a new documentation page for recommended lectures.

  • Add Recommended lectures page and link it in the docs sidebar.
  • Update L2 (TDX build and prover) and L1 PR workflows to ignore docs changes.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/SUMMARY.md Adds a sidebar link to the new Recommended lectures page.
docs/LECTURES.md Introduces a new docs page with curated lecture links.
.github/workflows/pr-main_l2_tdx_build.yaml Skips workflow on PRs that only change files under docs/**.
.github/workflows/pr-main_l2_prover.yaml Skips workflow on PRs that only change files under docs/**.
.github/workflows/pr-main_l1.yaml Skips workflow on PRs that only change files under docs/**.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 4 to +8
branches: ["main"]
pull_request:
branches: ["**"]

paths-ignore:
- "docs/**" # Documentation changes don't need to run the full workflow
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only commits pushed to main will still trigger this workflow because paths-ignore is only configured for pull_request. To fully avoid running on documentation-only edits, also add paths-ignore under push.

Copilot uses AI. Check for mistakes.

Comment on lines 4 to +8
branches: ["main"]
pull_request:
branches: ["**"]
paths-ignore:
- "docs/**" # Documentation changes don't need to run the full workflow
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only commits pushed to main will still trigger this workflow because paths-ignore is only configured for pull_request. Mirror the ignore rule under push to prevent unnecessary runs on documentation-only changes.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: In Review
Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant