Skip to content

perf(l1,l2): reduce allocation in Nibbles #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf(l1,l2): reduce allocation in Nibbles #4913

wants to merge 3 commits into from
+41 −50

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Oct 16, 2025

Since path-based tries we've increased the allocations in Nibbles, and
it shows a significant (65%) impact on apply_account_updates_from_trie_batch.
This changes how consumed nibbles are tracked to avoid the extra
allocations.

@Oppen
perf(l1,l2): reduce allocation in Nibbles
272f765 
Since path-based tries we've increased the allocations in `Nibbles`, and
it shows a significant (65%) impact on `apply_account_updates_from_trie_batch`.
This changes how consumed nibbles are tracked to avoid the extra
allocations.
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client performance labels Oct 16, 2025
@github-actions GitHub Actions
Copy link

Lines of code report

Total lines added: 0
Total lines removed: 12
Total lines changed: 12

Detailed view 
+--------------------------------------+-------+------+
| File                                 | Lines | Diff |
+--------------------------------------+-------+------+
| ethrex/crates/common/trie/nibbles.rs | 294   | -12  |
+--------------------------------------+-------+------+

@github-actions GitHub Actions
Copy link

Benchmark for 4a8c0be

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 37.9±1.88ms 35.8±0.70ms -5.54%
Trie/cita-trie insert 1k 3.5±0.02ms 3.5±0.12ms 0.00%
Trie/ethrex-trie insert 10k 63.6±0.85ms 62.8±1.39ms -1.26%
Trie/ethrex-trie insert 1k 8.0±0.02ms 8.0±0.15ms 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for fd27b15

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 37.5±1.74ms 38.0±1.62ms +1.33%
Trie/cita-trie insert 1k 3.5±0.01ms 3.6±0.10ms +2.86%
Trie/ethrex-trie insert 10k 63.6±0.86ms 63.5±0.97ms -0.16%
Trie/ethrex-trie insert 1k 8.0±0.07ms 7.9±0.04ms -1.25%

@github-actions GitHub Actions
Copy link

Benchmark for 29dae06

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 35.2±0.28ms 35.0±0.59ms -0.57%
Trie/cita-trie insert 1k 3.6±0.01ms 3.5±0.03ms -2.78%
Trie/ethrex-trie insert 10k 62.5±0.46ms 62.0±1.40ms -0.80%
Trie/ethrex-trie insert 1k 8.2±0.03ms 8.0±0.13ms -2.44%

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 90.265 ± 0.244 90.039 90.864 1.01 ± 0.00
head 89.811 ± 0.212 89.484 90.298 1.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@Oppen Oppen

Labels

L1 Ethereum client L2 Rollup client performance

Projects

ethrex_l1
Status: No status
ethrex_l2
Status: No status
ethrex_performance
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Oppen @pablodeymo