fix(l1,l2): dont set latest tag when making pre-releases
#4915
+35
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where pre-release versions (tagged with -rc) incorrectly override the latest tag in Docker image publishing. The changes introduce conditional logic to determine which tags should be applied based on whether the release is a pre-release or a stable release.
- Adds conditional tag selection logic that checks for
-rcsuffix in version tags - Separates L1 and L2 Docker image tags into environment variables for conditional application
- Excludes
latestandl2tags for pre-release versions while maintaining version-specific tags
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jrchatruc
approved these changes
Oct 17, 2025
fedacking
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When pre-releasing drafts (with
-rc), we are overriding thelatesttag.Description