fix: remove enforce selector constraint #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 94.87% 93.26% -1.62%
==========================================
Files 33 33
Lines 7069 6773 -296
==========================================
- Hits 6707 6317 -390
- Misses 362 456 +94
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
schouhy
reviewed
Aug 30, 2023
cairo_prover/Cargo.toml
Outdated
Comment on lines
9
to
11
| [[bin]] | ||
| name = "cairo-platinum" | ||
| path = "src/main.rs" |
There was a problem hiding this comment.
There was a recent pr merged to main that modified the Makefile to use cairo-platinum-prover as the name of the binary. That should be reverted if this change is merged to main
diegokingston
approved these changes
Aug 30, 2023
schouhy
reviewed
Aug 30, 2023
|
|
||
| let memory_holes = get_memory_holes(&address_cols, public_input.public_memory.len()); | ||
| let memory_holes = get_memory_holes(&address_cols, public_input.codelen); | ||
| // let memory_holes = get_memory_holes(&address_cols, public_input.public_memory.len()); |
There was a problem hiding this comment.
this line should be removed
schouhy
approved these changes
Aug 30, 2023
ajgara
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the enforce selector constraint from the Cairo AIR.
IMPORTANT NOTE: For the moment, since we need programs compiled in proof mode, Cairo 1 programs will not be supported.