Optimize svo implementation #3
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the protocol implementation.
The following optimizations were implemented:
Parallelized the main accumulator loop to distribute the heavy workload across all available CPU cores.
Eliminated heap allocations in hot loops by refactoring functions (
compute_p_beta, etc.
) to use mutable, stack-allocated buffers instead of returning new Vecs on each call. This significantly reduces pressure on the memory allocator and removes contention between threads.Introduced a polynomial transposition pre-computation step (
transpose_poly_for_svo
) to ensure sequential memory access. This dramatically improves CPU cache utilization by converting a slow, strided memory access pattern into cache-friendly contiguous reads.Results
Initial run
After optimizations