-
Notifications
You must be signed in to change notification settings - Fork 26
fix: add blobstorage config #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7d7d2d
to
7fded2b
Compare
@@ -171,8 +171,6 @@ Template containing common environment variables that are used by several servic | |||
key: clickhouse_tls | |||
- name: LOG_LEVEL | |||
value: {{ .Values.config.logLevel }} | |||
- name: FF_WORKSPACE_SCOPE_ORG_INVITES_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit unrelated to your PR, maybe all non-conditional env vars should just be at the top of commonEnv
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, i inteneded to make this one conditional as well which is why imoved it 🤦
Add the ability to configure s3 using access key/secret. Workload identity support coming soon