Skip to content

fix: add blobstorage config #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 16, 2024
Merged

fix: add blobstorage config #125

merged 7 commits into from
Jul 16, 2024

Conversation

langchain-infra
Copy link
Contributor

Add the ability to configure s3 using access key/secret. Workload identity support coming soon

@langchain-infra langchain-infra changed the title fix: add s3 config fix: add blobstorage config Jul 16, 2024
@@ -171,8 +171,6 @@ Template containing common environment variables that are used by several servic
key: clickhouse_tls
- name: LOG_LEVEL
value: {{ .Values.config.logLevel }}
- name: FF_WORKSPACE_SCOPE_ORG_INVITES_ENABLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit unrelated to your PR, maybe all non-conditional env vars should just be at the top of commonEnv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, i inteneded to make this one conditional as well which is why imoved it 🤦

@langchain-infra langchain-infra merged commit 72c72a0 into main Jul 16, 2024
1 check passed
@langchain-infra langchain-infra deleted the infra/add-s3-config branch July 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants