Skip to content

Conversation

@deon-sanchez
Copy link
Collaborator

@deon-sanchez deon-sanchez commented Jan 21, 2026

This pull request makes a minor update to the extractColumnsFromRows utility function by removing the tooltipField property from the column definition. This change will prevent tooltips from automatically displaying the field value in the table.

FIX

Screen.Recording.2026-01-21.at.12.27.11.PM.mov

BUG

Screen.Recording.2026-01-21.at.12.27.51.PM.mov

JIRA: https://datastax.jira.com/browse/LFOSS-3291?atlOrigin=eyJpIjoiNDI2OTkyNGIwMjQzNDk3Mzk3YjVhZTc5MmIzYzRjMmYiLCJwIjoiaiJ9

Summary by CodeRabbit

  • Bug Fixes
    • Union mode columns will no longer display unwanted tooltips.

✏️ Tip: You can customize this high-level summary in your review settings.

@deon-sanchez deon-sanchez self-assigned this Jan 21, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

This PR removes a single line of code from the extractColumnsFromRows function in the utils module. When the mode is "union", column definitions previously included a tooltipField property assignment, which is now deleted.

Changes

Cohort / File(s) Summary
Tooltip field removal
src/frontend/src/utils/utils.ts
Removed tooltipField: key property assignment from union-mode column definitions in extractColumnsFromRows function

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 3
❌ Failed checks (1 error, 1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error The PR modifies extractColumnsFromRows to remove tooltipField, but no test files are included to verify the fix or provide regression coverage. Add test coverage validating that tooltipField is not added in union mode and tooltips no longer obstruct navigation.
Test File Naming And Structure ⚠️ Warning The pull request removes a line from extractColumnsFromRows function without adding corresponding test coverage for the change. Add test file src/frontend/src/utils/tests/extractColumnsFromRows.test.ts with tests for union/intersection modes, excludeColumns parameter, empty rows, and edge cases.
Test Quality And Coverage ❓ Inconclusive Unable to locate or verify test coverage for the modified utility function in this PR. Verify that tests exist for the extractColumnsFromRows function and confirm whether new tests were added to cover the removed tooltipField property change.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Excessive Mock Usage Warning ✅ Passed The custom check for 'Excessive Mock Usage Warning' is not applicable to this PR. The PR contains only a single-line modification to src/frontend/src/utils/utils.ts, removing the tooltipField property from column definitions. Since this PR does not modify any test files and the custom check is designed to review test files for excessive mock usage patterns, there is no scope for this check to evaluate within these changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: removing tooltips that obstruct navigation in the table view.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lfoss-3291

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 17%
17.55% (5029/28651) 10.89% (2403/22052) 11.64% (731/6276)

Unit Test Results

Tests Skipped Failures Errors Time
2006 0 💤 0 ❌ 0 🔥 25.598s ⏱️

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.75%. Comparing base (700ae9b) to head (c87e190).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (41.63%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11396   +/-   ##
=======================================
  Coverage   34.75%   34.75%           
=======================================
  Files        1417     1417           
  Lines       67658    67658           
  Branches     9931     9931           
=======================================
  Hits        23517    23517           
  Misses      42917    42917           
  Partials     1224     1224           
Flag Coverage Δ
frontend 16.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frontend/src/utils/utils.ts 16.90% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 21, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 21, 2026
@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 22, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 22, 2026
@github-actions github-actions bot removed the bug Something isn't working label Jan 22, 2026
@github-actions github-actions bot added the bug Something isn't working label Jan 22, 2026
@deon-sanchez deon-sanchez changed the title fix: Table view tooltips obstruct navigation fix: table view tooltips obstruct navigation Jan 22, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 22, 2026
@deon-sanchez deon-sanchez added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit d4e3791 Jan 22, 2026
41 of 44 checks passed
@deon-sanchez deon-sanchez deleted the lfoss-3291 branch January 22, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants